optimize PathIndex walk for large repos - #5
Merged
Merged
Conversation
PathIndex walked every file including .git internals and opened every file for line counting. On repos with millions of files (e.g. game engines with binary assets), session_start exceeded MCP tool timeout. Two configurable constants control the behavior: - WALK_EXCLUDE_DIRS: directories never descended into (.git) - BINARY_EXTENSIONS: ~100 extensions that get stat-only indexing (size captured, marked isBinary, no fd opened) Binary-extension files remain in the index for find_files and grep -- only line counting is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git/directories during filesystem walk (WALK_EXCLUDE_DIRSconstant)BINARY_EXTENSIONSconstant) -- stat-only indexing, no fd openedContext
Dagor repo has 3.5M files. PathIndex opened every file for line counting, causing
session_startto exceed MCP tool timeout. Binary-extension files (images, audio, models, shaders, game assets) now get stat-only indexing -- they remain in the index forfind_filesandgrepbut skip the expensiveLineIterscan.Test plan
vp checkclean (formatting, lint, types)